mapleFU commented on code in PR #35464:
URL: https://github.com/apache/arrow/pull/35464#discussion_r1201436576
##########
cpp/src/arrow/acero/query_context.cc:
##########
@@ -23,10 +23,19 @@ namespace arrow {
using arrow::internal::CpuInfo;
namespace acero {
+namespace {
+io::IOContext GetIoContext(QueryOptions& opts, const ExecContext&
exec_context) {
Review Comment:
I think exec_context can be make as constant, but custom_io_executor should
be non-const, so QueryOptions cannot have const. Should I use `mutable` for
`io::Executor custom_io_executor` or some other methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
