eerhardt commented on code in PR #697:
URL: https://github.com/apache/arrow-adbc/pull/697#discussion_r1202444774


##########
csharp/src/Apache.Arrow.Adbc/Extensions/MatchCollectionExtensions.netstandard.cs:
##########
@@ -0,0 +1,23 @@
+#if NETSTANDARD
+using System.Collections.Generic;
+using System.Linq;
+using System.Text.RegularExpressions;
+
+namespace System.Text.RegularExpressions
+{
+    public static class MatchCollectionExtensions
+    {
+        public static IEnumerable<Match> Where(this MatchCollection 
matchCollection, Func<Match,bool> predicate)

Review Comment:
   Let's not make this public. You can rewrite the only usage of this method in 
`ParseDecimalValueFromOverflowException` as:
   
   ```C#
               var matches = regex.Matches(oex.Message);
               foreach (Match match in matches)
               {
                   string value = match.Value;
                   if (!string.IsNullOrEmpty(value))
                   {
                       return value;
                   }
               }
   
               throw oex;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to