pitrou commented on PR #35737: URL: https://github.com/apache/arrow/pull/35737#issuecomment-1560930716
@kou Have you already seen this GLib compile error (which seems unrelated to this PR): https://github.com/apache/arrow/actions/runs/5065962799/jobs/9098866403#step:10:190 ``` [44/121] Compiling C++ object arrow-glib/libarrow-glib-1300.dll.p/compute.cpp.obj In file included from ../../c_glib/arrow-glib/compute.cpp:28: ../../c_glib/arrow-glib/error.hpp: In instantiation of 'gboolean garrow::check(GError**, const arrow::Status&, CONTEXT_FUNC&&) [with CONTEXT_FUNC = garrow_array_cast(GArrowArray*, GArrowDataType*, GArrowCastOptions*, GError**)::<lambda()>&; gboolean = int; GError = _GError]': ../../c_glib/arrow-glib/error.hpp:71:17: required from 'gboolean garrow::check(GError**, const arrow::Result<T>&, CONTEXT_FUNC&&) [with TYPE = std::shared_ptr<arrow::Array>; CONTEXT_FUNC = garrow_array_cast(GArrowArray*, GArrowDataType*, GArrowCastOptions*, GError**)::<lambda()>; gboolean = int; GError = _GError]' ../../c_glib/arrow-glib/compute.cpp:4609:20: required from here ../../c_glib/arrow-glib/error.hpp:49:19: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] 49 | std::string context = std::move(context_func()); | ^~~~~~~ ../../c_glib/arrow-glib/error.hpp:49:19: note: remove 'std::move' call ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
