paleolimbot commented on code in PR #702:
URL: https://github.com/apache/arrow-adbc/pull/702#discussion_r1204593665
##########
python/adbc_driver_manager/adbc_driver_manager/_lib.pyx:
##########
@@ -460,6 +461,18 @@ cdef class _AdbcHandle:
f"with open {self._child_type}")
+cdef void pycapsule_stream_deleter(object stream_capsule):
+ cdef:
+ CArrowArrayStream* stream
+ # Do not invoke the deleter on a used/moved capsule
+ stream = <CArrowArrayStream*>cpython.PyCapsule_GetPointer(
+ stream_capsule, 'arrowarraystream'
+ )
Review Comment:
It seems like it is not possible anyway (
https://docs.python.org/3/c-api/capsule.html#c.PyCapsule_New ) and would only
ever occur on error (perhaps if there was a capsule name mismatch). The fact
that this can happen in R is a peculiarity of R's save/load...it seems unlikely
in the destructor here but perhaps worth checking to avoid a crash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
