paleolimbot opened a new pull request, #708:
URL: https://github.com/apache/arrow-adbc/pull/708
I think initially I thought this would be useful for printing, but it turns
out it's distressingly easy to print out/leak/expose secret credentials with
the default print method:
``` r
library(adbcdrivermanager)
uri <- Sys.getenv("ADBC_SNOWFLAKE_TEST_URI")
adbc_database_init(adbcsnowflake::adbcsnowflake(), uri = uri)
#> <adbcsnowflake_database> <pointer: 0x14f65c350> List of 2
#> $ driver :<adbcsnowflake_driver_snowflake> List of 1
#> ..$ driver_init_func:Class 'adbc_driver_init_func' <externalptr>
#> $ options:List of 1
#> ..$ uri: chr
"paleolimbot:[email protected]/SNOWFLAKE_SAMPLE_DATA/TPCH_SF1?role=ACCOUNTADMIN"
```
This PR nixes that whole system: if it's helpful to expose something it can
be exposed by individual drivers. After this PR:
``` r
library(adbcdrivermanager)
uri <- Sys.getenv("ADBC_SNOWFLAKE_TEST_URI")
adbc_database_init(adbcsnowflake::adbcsnowflake(), uri = uri)
#> <adbcsnowflake_database> <pointer: 0x15365d570> List of 1
#> $ driver:<adbcsnowflake_driver_snowflake> List of 1
#> ..$ driver_init_func:Class 'adbc_driver_init_func' <externalptr>
```
<sup>Created on 2023-05-24 with [reprex
v2.0.2](https://reprex.tidyverse.org)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
