yevgenypats commented on PR #35687: URL: https://github.com/apache/arrow/pull/35687#issuecomment-1562480932
> Hi @zeroshade! > > I'm overtaking this PR from @yevgenypats. > > I've extracted timestamp from numeric gen (array, builder, tests, traits). > > Additionally, I propose to introduce a helper func for creation of `arrow.Timestamp` from `time.Time` and `arrow.TimeUnit`. > > The logic was tested and introduced in [cloudquery#17](https://github.com/cloudquery/arrow/pull/17) (in this PR: [1689eee](https://github.com/apache/arrow/commit/1689eee0ec81da6e62f545eb06f8f71ed3f69a22)). > > UPD: it seems there's a [flaky](https://github.com/apache/arrow/actions/runs/5077433733/jobs/9120706233?pr=35687#step:5:739) test (`go/arrow/flight/flightsql/driver/driver_test.go:741`, `TestPreparedStatementNoSchema`) Thanks @candiduslynx ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
