mapleFU commented on code in PR #35731: URL: https://github.com/apache/arrow/pull/35731#discussion_r1205544371
########## cpp/src/parquet/bloom_filter_benchmark.cc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "benchmark/benchmark.h" + +#include "parquet/bloom_filter.h" + +#include <random> + +namespace parquet { +namespace benchmark { + +constexpr static uint32_t kBloomFilterElementSize = 1024; Review Comment: > I'm curious, is this a typical bloom filter size? Given that bloom filters are grouped by row group, I would perhaps expect a larger value? (row groups are typically quite large) It's an element size, maybe I can make it 10000, because our system default using 10000 as row-group stride? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
