pitrou commented on code in PR #35758: URL: https://github.com/apache/arrow/pull/35758#discussion_r1205655970
########## cpp/src/parquet/metadata_test.cc: ########## @@ -66,7 +66,6 @@ std::unique_ptr<parquet::FileMetaData> GenerateTableMetaData( // column metadata col1_builder->SetStatistics(stats_int); col2_builder->SetStatistics(stats_float); - dict_encoding_stats.clear(); Review Comment: Why remove this line? Since `/*has_dictionary=*/false` below, perhaps we need to pass empty dict encoding stats? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
