lidavidm commented on code in PR #709:
URL: https://github.com/apache/arrow-adbc/pull/709#discussion_r1205897211
##########
.pre-commit-config.yaml:
##########
@@ -86,5 +86,10 @@ repos:
language: script
pass_filenames: false
entry: "./ci/scripts/run_rat_local.sh"
+ - id: check-cgo-adbc-header
+ name: Ensure CGO adbc.h is sync'd
+ language: script
+ pass_filenames: false
+ entry: "./ci/scripts/run_cgo_drivermgr_check.sh"
Review Comment:
Maybe include a [`files`](https://pre-commit.com/#hooks-files) filter so
this only runs when necessary?
You could go a step further and have it pass filenames, then the script
could check each of the given files against its copy in `go/adbc/drivermgr`
(that might be a bit too fancy though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
