tustvold commented on code in PR #4280:
URL: https://github.com/apache/arrow-rs/pull/4280#discussion_r1205913384
##########
parquet/src/column/writer/mod.rs:
##########
@@ -1512,7 +1528,7 @@ mod tests {
metadata.encodings(),
&vec![Encoding::PLAIN, Encoding::RLE, Encoding::RLE_DICTIONARY]
);
- assert_eq!(metadata.num_values(), 8); // dictionary + value indexes
+ assert_eq!(metadata.num_values(), 4);
Review Comment:
I will split it out into a separate PR, but keep it here as otherwise I need
to add logic to ArrowPageWriter to reproduce what I'm certain is an incorrect
behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
