liurenjie1024 commented on PR #6435: URL: https://github.com/apache/arrow-datafusion/pull/6435#issuecomment-1563703996
Oh, I didn't notice that we already have tpch verification in ci, so another round of tpch verification would not be necessary. The main goal of this pr is to move tpch test in benchmark into sqllogictest to make it easier to maintain, so I will remove unnecessary changes to avoid. > Figure out some way to run the tpch tests conditionally in CI (maybe an environment variable or a flag 🤔 ) so they still pass even when the data generator hasn't been run. Do we really need to make it conditional? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
