wjones127 commented on code in PR #478: URL: https://github.com/apache/arrow-adbc/pull/478#discussion_r1207209397
########## rust/src/error.rs: ########## @@ -0,0 +1,193 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! ADBC error enums and structs + +use arrow_schema::ArrowError; + +#[derive(Debug, PartialEq, Copy, Clone)] +#[repr(u8)] +pub enum AdbcStatusCode { + /// No error. + Ok = 0, Review Comment: This part is meant to be FFI compatible with the C error codes (probably should have documented that). Although yeah this does provide a redundant state. Maybe the best solution is to drop this value from the Rust enum, and then handle the conversion of `0` into `Result::Ok` within the C API FFI codebase. 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
