LouisGariepy opened a new pull request, #6464: URL: https://github.com/apache/arrow-datafusion/pull/6464
# Which issue does this PR close? Closes #207. # Rationale for this change This PR fixes most of the remaining clippy `allow`s remaining in the code base. Clippy `allow`s sometimes silence actually useful lints. Even if the lint was not useful at some point, it's easy to forget about them even after the code has been fixed. For these reasons it's good practice to clean them up once in a while. # What changes are included in this PR? The bulk of the changes is simply removing `allows` the were not needed at all. Some changes are slightly more involved, but should still be pretty localized and self-explanatory. # Are these changes tested? This PR does not (and should not) introduce new features or modify existing features. Thus, existing test coverage should be sufficient. I added one test to for the code I added for data pointer equality (related to the removal of [vtable address comparison](https://rust-lang.github.io/rust-clippy/master/index.html#vtable_address_comparisons) lints # Are there any user-facing changes? No(*) (see the Notes section below) # Notes All of the committed fixes are fairly straightforward and uncontroversial. Some fixes would be breaking(*) or require maintainer input to get right. I documented these cases with `TODO(clippy)` and gave ample details and potential solutions. *I would appreciate if the reviewer could pay special attention to these so we can decide which ones should be fixed as part of this PR, which ones should be fixed as part of a separate PR, and which ones should not be fixed at all*. The remaining `allow`s are all [too many arguments](https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments) lints whose fixes are not straightforward and might require some more in-depth redesign. I'm proposing to leave them as is for now and fix them on a case-by-case basis as solutions become more evident. I did not mark these with `TODO(clippy)` as I can't suggest solutions for them without some more careful examination. I will try to get to them in due time, in one or more future PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
