berkaysynnada opened a new pull request, #6469:
URL: https://github.com/apache/arrow-datafusion/pull/6469
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #6468.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
If we try to assign 2 or more orderings to a table with `CREATE EXTERNAL
TABLE`, we cannot express it with multiple WITH ORDER's. With this PR, we can
create such tables like this:
```
CREATE EXTERNAL TABLE multiple_ordered_table (
...
)
STORED AS CSV
WITH HEADER ROW
WITH ORDER (a ASC, b ASC)
WITH ORDER (c ASC)
LOCATION '...';
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Parser can handle multiple WITH ORDER options. In the codebase, output
orderings are in the type of `Option<Vec<PhysicalSortExpr>>`. It is refactored
as `Vec<Vec<PhysicalSortExpr>>`.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, related slt tests are added showing the usage of feature on plans.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
The ListingOptions API is changed from
`pub fn with_file_sort_order(mut self, file_sort_order: Option<Vec<Expr>>)
-> Self ` to
`pub fn with_file_sort_order(mut self, file_sort_order: Vec<Vec<Expr>>) ->
Self`. This change was necessary to give all sort orderings at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
