alamb commented on code in PR #4294:
URL: https://github.com/apache/arrow-rs/pull/4294#discussion_r1207920019
##########
arrow-flight/src/lib.rs:
##########
@@ -433,24 +464,45 @@ impl FlightDescriptor {
}
impl FlightInfo {
- /// Create a new [`FlightInfo`] that describes the access
- /// coordinates for retrieval of a dataset.
- pub fn new(
- message: IpcMessage,
- flight_descriptor: Option<FlightDescriptor>,
- endpoint: Vec<FlightEndpoint>,
- total_records: i64,
- total_bytes: i64,
- ordered: bool,
- ) -> Self {
- let IpcMessage(vals) = message;
+ /// Create a new, empty `FlightInfo`, describing where to fetch flight data
Review Comment:
Rather than making a new `FlightInfoBuilder` I eventually decided to just
add the builder style methods on `FlightInfo` itself:
1. It was simpler code
2. I wasn't entirely sure what was valid / invalid semantically, so extra
error checking seemed unecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
