roeap commented on code in PR #4296:
URL: https://github.com/apache/arrow-rs/pull/4296#discussion_r1209461466
##########
arrow-flight/examples/flight_sql_server.rs:
##########
@@ -248,32 +255,106 @@ impl FlightSqlService for FlightSqlServiceImpl {
async fn get_flight_info_catalogs(
&self,
- _query: CommandGetCatalogs,
- _request: Request<FlightDescriptor>,
+ query: CommandGetCatalogs,
+ request: Request<FlightDescriptor>,
) -> Result<Response<FlightInfo>, Status> {
- Err(Status::unimplemented(
- "get_flight_info_catalogs not implemented",
- ))
+ let flight_descriptor = request.into_inner();
+ let ticket = Ticket {
+ ticket: query.encode_to_vec().into(),
+ };
+
+ let options = IpcWriteOptions::default();
+
+ // encode the schema into the correct form
+ let IpcMessage(schema) = SchemaAsIpc::new(get_catalogs_schema(),
&options)
+ .try_into()
+ .expect("valid catalogs schema");
Review Comment:
In this case the function is essentially infallible, since the passed schema
is valid and static. So the expect is more or less just a slightly more
expressive unwrap :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
