lidavidm commented on code in PR #714:
URL: https://github.com/apache/arrow-adbc/pull/714#discussion_r1210251609
##########
c/driver/postgresql/connection.cc:
##########
@@ -72,12 +72,44 @@ class PqResultRow {
// as expected prior to iterating
class PqResultHelper {
public:
- PqResultHelper(PGconn* conn, const char* query) : conn_(conn) {
+ PqResultHelper(PGconn* conn, const char* query, std::vector<std::string>
param_values,
+ struct AdbcError* error)
+ : conn_(conn), param_values_(param_values), error_(error) {
Review Comment:
I suppose if we need to pass integer parameters in the future or something.
But it's not a worry for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
