nealrichardson commented on issue #35710: URL: https://github.com/apache/arrow/issues/35710#issuecomment-1568623586
Thanks for the report! > 1. There's a new script to check whether the library version and the R package version are compatible. This is fine, but for arrow 11, there are versions 11.0.0.2 and 11.0.0.3 on CRAN. The script does not remove the fourth component, and thus it stops when it finds that 11.0.0 != 11.0.0.3. My understanding is that versions a.b.c.d of the R package should be considered compatible to a.b.c of the library. Have you encountered a scenario where you have a C++ library with version x.0.0.2 and R package with x.0.0.3? The `.d` releases are typically things we have to do to patch the R package for CRAN, so there is no corresponding C++ release with `.d`. > 2. `LIB_DIR` is hardcoded [here](https://github.com/apache/arrow/blob/f3500f65c0b15e285cba2b1822385248b3424f84/r/configure#L266) to `something/lib`. In many systems, this is `lib64`, not `lib`, and `pkgconfig` provides this info. Good catch. It was always hard-coded for the non-`pkg-config` path, and I found that the previous way we were doing it with pkg-config, of using `sed` to get it from `--libs-only-L`, didn't behave well if there were other dirs in the search path, so I just dropped back to the hard-coded for all. But it looks like arrow.pc does include it as `libdir`, so we can get it as `--variable=libdir` for that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
