tustvold commented on code in PR #4311:
URL: https://github.com/apache/arrow-rs/pull/4311#discussion_r1210487779
##########
parquet/src/arrow/schema/mod.rs:
##########
@@ -401,7 +401,8 @@ fn arrow_to_parquet_type(field: &Field) -> Result<Type> {
.with_length(*length)
.build()
}
- DataType::Decimal128(precision, scale) => {
+ DataType::Decimal128(precision, scale)
+ | DataType::Decimal256(precision, scale) => {
Review Comment:
As parquet doesn't have a distinction between Decimal128 and Decimal256 it
stands to reason that the logic to infer the corresponding physical type should
not draw a distinction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
