pitrou commented on PR #35731: URL: https://github.com/apache/arrow/pull/35731#issuecomment-1568731905
Thanks @mapleFU . I've pushed some changes to improve some benchmarks and also to improve `BloomFilter::Find` performance (around 2x faster). Current benchmarks here: ```` --------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... --------------------------------------------------------------------------------------------- BM_ComputeHash<Int32Type> 715521 ns 715427 ns 951 items_per_second=22.901M/s BM_ComputeHash<Int64Type> 740955 ns 740872 ns 878 items_per_second=22.1145M/s BM_ComputeHash<FloatType> 720903 ns 720789 ns 946 items_per_second=22.7306M/s BM_ComputeHash<DoubleType> 691569 ns 691479 ns 1005 items_per_second=23.6941M/s BM_ComputeHash<ByteArrayType> 706878 ns 706770 ns 986 items_per_second=23.1815M/s BM_ComputeHash<FLBAType> 762304 ns 762178 ns 941 items_per_second=21.4963M/s BM_ComputeHash<Int96Type> 892253 ns 892111 ns 809 items_per_second=18.3654M/s BM_BatchComputeHash<Int32Type> 250193 ns 250154 ns 2858 items_per_second=65.4957M/s BM_BatchComputeHash<Int64Type> 277338 ns 277289 ns 2518 items_per_second=59.0863M/s BM_BatchComputeHash<FloatType> 247188 ns 247143 ns 2832 items_per_second=66.2936M/s BM_BatchComputeHash<DoubleType> 278888 ns 278850 ns 2517 items_per_second=58.7557M/s BM_BatchComputeHash<ByteArrayType> 256035 ns 255996 ns 2740 items_per_second=64.0009M/s BM_BatchComputeHash<FLBAType> 252759 ns 252714 ns 2783 items_per_second=64.8323M/s BM_BatchComputeHash<Int96Type> 328592 ns 328540 ns 2119 items_per_second=49.8692M/s BM_InsertHash 689503 ns 689394 ns 1010 items_per_second=23.7658M/s BM_BatchInsertHash 496698 ns 496568 ns 1482 items_per_second=32.9945M/s BM_FindExistingHash 622037 ns 621724 ns 1126 items_per_second=26.3525M/s BM_FindNonExistingHash 658163 ns 657842 ns 1068 items_per_second=24.9057M/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
