alamb commented on code in PR #6481:
URL: https://github.com/apache/arrow-datafusion/pull/6481#discussion_r1210532436


##########
datafusion/core/tests/sqllogictests/test_files/select.slt:
##########
@@ -759,6 +759,64 @@ SELECT a FROM annotated_data_finite2
 0
 0
 
+# Below query should emit all the columns except a and b

Review Comment:
   Perhaps we can create a new table with columns that each have distinct 
values so it is clear what is happening?
   
   Something like
   
   ```sql
   create table t (a int, b int, c int, d int) as values (1, 10, 100, 1000), 
(2, 20, 200, 2000);
   ```
   
   That way the data definition can be close to the tests and it will be clear 
from the values what columns were actually selected 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to