Dandandan commented on pull request #8900: URL: https://github.com/apache/arrow/pull/8900#issuecomment-744033619
@alamb Took it a bit further and the `assert!` is also having the same effect on your benchmark: commit 23c8ff28e56ccb381bcbb321dcbbb946d8fd7db0 ``` Hello, world! example_with_vec created array with 20000000 elements in 625.670877ms Completed finding bitset: 20000000 elements in 62.028751ms Completed finding bitset: 20000000 elements in 61.464365ms Completed finding bitset: 20000000 elements in 59.990842ms Completed finding bitset: 20000000 elements in 56.594087ms Completed finding bitset: 20000000 elements in 55.969562ms Completed finding bitset: 20000000 elements in 56.594535ms Completed finding bitset: 20000000 elements in 55.987112ms Completed finding bitset: 20000000 elements in 56.379664ms Completed finding bitset: 20000000 elements in 56.47164ms Completed finding bitset: 20000000 elements in 56.342637ms example_with_arrow created array with 20000000 elements in 773.245663ms Found 20000000 not in west in 72.449124ms Found 20000000 not in west in 74.481405ms Found 20000000 not in west in 75.160204ms Found 20000000 not in west in 75.033379ms Found 20000000 not in west in 75.064686ms Found 20000000 not in west in 75.221221ms Found 20000000 not in west in 75.979403ms Found 20000000 not in west in 76.288346ms Found 20000000 not in west in 74.639085ms Found 20000000 not in west in 73.664288ms ``` commit 3b67f70d670c8ba76f327fb4c8a757155d021f67 : ``` Hello, world! example_with_vec created array with 20000000 elements in 550.194933ms Completed finding bitset: 20000000 elements in 58.936386ms Completed finding bitset: 20000000 elements in 57.900239ms Completed finding bitset: 20000000 elements in 54.868759ms Completed finding bitset: 20000000 elements in 52.913171ms Completed finding bitset: 20000000 elements in 52.707473ms Completed finding bitset: 20000000 elements in 53.600913ms Completed finding bitset: 20000000 elements in 53.315755ms Completed finding bitset: 20000000 elements in 53.188747ms Completed finding bitset: 20000000 elements in 52.896293ms Completed finding bitset: 20000000 elements in 54.134426ms example_with_arrow created array with 20000000 elements in 666.080968ms Found 20000000 not in west in 58.209991ms Found 20000000 not in west in 58.496839ms Found 20000000 not in west in 58.294964ms Found 20000000 not in west in 57.771822ms Found 20000000 not in west in 58.266169ms Found 20000000 not in west in 58.028011ms Found 20000000 not in west in 58.431954ms Found 20000000 not in west in 58.545879ms Found 20000000 not in west in 58.131794ms Found 20000000 not in west in 59.211415ms ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
