seddonm1 commented on a change in pull request #8892:
URL: https://github.com/apache/arrow/pull/8892#discussion_r541999967
##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -363,9 +363,9 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query:
usize) -> Result<Logic
from
lineitem
where
- l_shipdate >= '1994-01-01'
- and l_shipdate < '1995-01-01'
- and l_discount between 0.06 - 0.01 and 0.06 + 0.01
+ l_shipdate >= date '1994-01-01'
+ and l_shipdate < date '1995-01-01'
+ and l_discount > 0.06 - 0.01 and l_discount < 0.06 + 0.01
Review comment:
Actually, no. The raw query as per TPC-H does not use between for that
clause:
```sql
where l_shipdate >= date '[DATE]'
and l_shipdate < date '[DATE]' + interval '1' year
and l_discount between [DISCOUNT] - 0.01 and [DISCOUNT] + 0.01
```
Which is different as BETWEEN is inclusive (`>=` AND `<=`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
