mustafasrepo opened a new pull request, #6501:
URL: https://github.com/apache/arrow-datafusion/pull/6501
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
`OrderedColumn` struct keeps columns that have ordering, with ordering
information. This struct is used during `OrderingEquivalence` calculations.
However, existing `PhysicalSortExpr` can keep track of this information. Also
`PhysicalSortExpr` supports not just, columns but complex expressions also.
We can use `PhysicalSortExpr` instead of `OrderedColumn`.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
This PR removes `OrderedColumn` struct and uses `PhysicalSortExpr` in its
place.
However, because `PhysicalSortExpr` doesn't implement `Hash` trait (there is
no trivial way to support this trait if any). We changed the `EquivalentClass`
implementation so that it doesn't require `Hash` trait anymore.
For this reason, we have replaced places in `EquivalentClass` where
`HashSet` is used with `Vector`.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
Yes existing tests should work, also new test is added (under `window.slt`
file) to show that we can use complex expressions (not just Columns) during
ordering equivalence calculations.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
