jorisvandenbossche commented on code in PR #35036:
URL: https://github.com/apache/arrow/pull/35036#discussion_r1211484596
##########
cpp/src/arrow/array/data.cc:
##########
@@ -236,6 +236,18 @@ void SetOffsetsForScalar(ArraySpan* span, offset_type*
buffer, int64_t value_siz
span->buffers[buffer_index].size = 2 * sizeof(offset_type);
}
+template <typename RunEndType>
+void FillRunEndsArrayForScalar(ArraySpan* span, const DataType* run_end_type) {
Review Comment:
Yes, the tests for scalar kernels automatically run the kernel also on
actual scalars, and then this ends up creating an array from the scalar. So
those changes to `FillFromScalar` are needed to be able to run any kernel on a
REE scalar.
At the moment we don't actually have any test for `FillFromScalar` directly
(also not for other types), only through testing the kernels on scalars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
