thisisnic commented on code in PR #35667:
URL: https://github.com/apache/arrow/pull/35667#discussion_r1211606915
##########
r/tests/testthat/test-dplyr-filter.R:
##########
@@ -425,3 +425,34 @@ test_that("filter() with across()", {
tbl
)
})
+
+test_that(".by argument", {
+ compare_dplyr_binding(
+ .input %>%
+ filter(is.na(lgl), .by = chr) %>%
+ select(chr, int, lgl) %>%
+ collect(),
+ tbl
+ )
+ compare_dplyr_binding(
+ .input %>%
+ filter(.by = chr) %>%
+ select(chr, int, lgl) %>%
+ collect(),
+ tbl
+ )
+ compare_dplyr_binding(
+ .input %>%
+ filter(int > 2, pnorm(dbl) > .99, .by = chr) %>%
+ collect(),
+ tbl,
+ warning = "Expression pnorm\\(dbl\\) > 0.99 not supported in Arrow;
pulling data into R"
+ )
Review Comment:
This test is pulling the data into R, so we end up comparing dplyr with
dplyr instead of Arrow. Is the purpose of this test to test with multiple
filters? If so, how about swapping `pnorm()` out for something else? Or is the
intention here different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
