icexelloss commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1211611870
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -1059,7 +1232,7 @@ class AsofJoinNode : public ExecNode {
// If RHS is finished, then we know it's up to date
if (rhs.CurrentEmpty())
return false; // RHS isn't finished, but is empty --> not up to date
- if (lhs_ts >= rhs.GetCurrentTime())
Review Comment:
Yes I think we should understand why this change is needed. This looks like
something subtle and can introduce tricky bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
