icexelloss commented on PR #34392: URL: https://github.com/apache/arrow/pull/34392#issuecomment-1570177595
No worries! Can open a follow up PR to address the remaining issues. On Wed, May 31, 2023 at 8:46 AM rtpsw ***@***.***> wrote: > Can you please add comments in the code to explain this. Looks like > something could tricky to understand just from the code. > > Will do. In the meantime, I'll note that we do not remove entries earlier > than a time ts when it is not in the past of latest_time, which is the > case when latest_time >= ts is false; otherwise, we would be removing > entries before processing them. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/34392#issuecomment-1570169322>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGBXLEFGGL7IIR2UHXQCJ3XI44UHANCNFSM6AAAAAAVLXLTPQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
