rtpsw commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1211673685
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -731,7 +898,9 @@ class InputState {
Status Push(const std::shared_ptr<arrow::RecordBatch>& rb) {
if (rb->num_rows() > 0) {
- queue_.Push(rb);
+ key_hasher_->Invalidate(); // batch changed - invalidate key hasher's
cache
+ memo_.UpdateTime(GetTime(rb.get(), 0)); // time changed - update in
MemoStore
Review Comment:
See [this
post](https://github.com/apache/arrow/pull/34392#discussion_r1211671161).
`UpdateTime` is synchronized, and before we didn't need this synchronization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
