candiduslynx commented on PR #35823: URL: https://github.com/apache/arrow/pull/35823#issuecomment-1570454564
> looks good in general to me, just one question about the `WithUnorderedMapKeys` vs just checking the `KeysSorted` member of the `MapType` and deciding to go with the Unordered check if `KeysSorted` is false. @zeroshade I've looked at the `KeysSorted` and it doesn't guarantee anything in the code (as well as the docstring for it states that this value isn't used in comparison in any way). I believe updating the code to use `KeysSorted` is a breaking change & it should also imply the need to check for the entries order in the builder. So, I'd rather go with `WithUnorderedMapKeys` option for now & let someone who is really sure they need this functionality open an issue for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
