kou commented on code in PR #35672:
URL: https://github.com/apache/arrow/pull/35672#discussion_r1212338912
##########
cpp/src/arrow/io/memory_test.cc:
##########
@@ -869,6 +870,7 @@ TEST(CacheOptions, Basics) {
check(CacheOptions::MakeFromNetworkMetrics(5, 500, .75, 5), 2.5, 5);
}
+#ifdef ARROW_ENABLE_THREADING
Review Comment:
Can we use `GTEST_SKIP` here like others?
##########
cpp/src/arrow/dataset/dataset_writer_test.cc:
##########
@@ -380,8 +381,11 @@ TEST_F(DatasetWriterTestFixture, MinRowGroupBackpressure) {
}
TEST_F(DatasetWriterTestFixture, ConcurrentWritesSameFile) {
- // Use a gated filesystem to queue up many writes behind a file open to make
sure the
- // file isn't opened multiple times.
+// Use a gated filesystem to queue up many writes behind a file open to make
sure the
+// file isn't opened multiple times.
+#ifndef ARROW_ENABLE_THREADING
+ GTEST_SKIP() << "Concurrent writes tests need threads";
+#endif
Review Comment:
```suggestion
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Concurrent writes tests need threads";
#endif
// Use a gated filesystem to queue up many writes behind a file open to
make sure the
// file isn't opened multiple times.
```
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -210,6 +210,8 @@ takes precedence over ccache if a storage backend is
configured" ON)
define_option(ARROW_WITH_MUSL "Whether the system libc is musl or not" OFF)
+ define_option(ARROW_ENABLE_THREADING "Enable threading in Arrow core." ON)
Review Comment:
```suggestion
define_option(ARROW_ENABLE_THREADING "Enable threading in Arrow core" ON)
```
##########
cpp/src/arrow/dataset/dataset_writer_test.cc:
##########
@@ -394,7 +398,10 @@ TEST_F(DatasetWriterTestFixture, ConcurrentWritesSameFile)
{
}
TEST_F(DatasetWriterTestFixture, ConcurrentWritesDifferentFiles) {
- // NBATCHES must be less than I/O executor concurrency to avoid deadlock /
test failure
+// NBATCHES must be less than I/O executor concurrency to avoid deadlock /
test failure
+#ifndef ARROW_ENABLE_THREADING
+ GTEST_SKIP() << "Concurrent writes tests need threads";
+#endif
Review Comment:
```suggestion
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Concurrent writes tests need threads";
#endif
// NBATCHES must be less than I/O executor concurrency to avoid deadlock /
test failure
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
