aiguofer commented on code in PR #572:
URL: https://github.com/apache/arrow-adbc/pull/572#discussion_r1212559765
##########
java/driver/flight-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/FlightSqlDriver.java:
##########
@@ -64,6 +64,11 @@ public AdbcDatabase open(Map<String, Object> parameters)
throws AdbcException {
} else {
quirks = new SqlQuirks();
}
- return new FlightSqlDatabase(allocator, location, (SqlQuirks) quirks);
+ return new FlightSqlDatabase(
+ allocator,
+ location,
+ (SqlQuirks) quirks,
+ (String) parameters.get("adbc.username"),
+ (String) parameters.get("adbc.password"));
Review Comment:
It might be better to pass the `parameters` instead. The `FlightSqlDatabase`
will need to know about all the params to decide how to build the
`FlightClient`. For example, all the TLS options.
It would also be nice to have dataclasses or static objects with all the
option values
https://arrow.apache.org/adbc/main/driver/go/flight_sql.html#client-options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
