tustvold commented on code in PR #6384:
URL: https://github.com/apache/arrow-datafusion/pull/6384#discussion_r1213009802
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -77,11 +81,40 @@ fn array_array(args: &[ArrayRef]) -> Result<ArrayRef> {
// do not accept 0 arguments.
if args.is_empty() {
return Err(DataFusionError::Internal(
- "array requires at least one argument".to_string(),
+ "Array requires at least one argument".to_string(),
));
}
- let res = match args[0].data_type() {
+ let data_type = args[0].data_type();
+ let res = match data_type {
+ DataType::List(..) => {
+ let arrays =
Review Comment:
It would perhaps be nicer to use a combination of
https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericListArray.html#method.try_new
and https://docs.rs/arrow-select/latest/arrow_select/concat/index.html
MutableArrayData is not the nicest API to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
