eitsupi commented on issue #35844: URL: https://github.com/apache/arrow/issues/35844#issuecomment-1572060666
> My concern here would be that using a tool which isn't widely known or adopted in the R community would reduce the number of lines of code in our tests, but ultimately further raise the barrier to entry for new contributors. > > I've also personally found that some previous attempts to reduce the amount of code (e.g. the use of `for` loops in some tests) has actually made things harder in the longer term when debugging failing tests, as it takes more effort to find the specific source of the test failure. Yes, there is definitely a tradeoff there. So I don't think I necessarily need to use `patrick`, I just wanted to suggest that it might be worth using. > Would you mind giving some examples of the places where the duplication seems most problematic? I think this is especially noticeable in the `mutate` tests: `mutate` has a derivative `transmute`, and which behaves differently depending on options such as `.keep` and `.by`, and with and without grouping. There is also a branch that performs calculations in R when a function not supported by arrow is included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
