pitrou commented on code in PR #35790:
URL: https://github.com/apache/arrow/pull/35790#discussion_r1213196322
##########
cpp/src/arrow/compute/api_vector.h:
##########
@@ -601,7 +596,7 @@ ARROW_EXPORT
Result<Datum> CumulativeSum(
const Datum& values,
const CumulativeSumOptions& options = CumulativeSumOptions::Defaults(),
- ExecContext* ctx = NULLPTR);
+ bool check_overflow = false, ExecContext* ctx = NULLPTR);
Review Comment:
Can you document the additional param in the docstring above?
Also, can you add a small test that the param is taken into account?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
