[GitHub] [arrow] wgtmac commented on a diff in pull request #35825: GH-32723: [C++][Parquet] Add option to use LARGE* variants of binary types

[via GitHub]

wgtmac commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1213304875


##########
cpp/src/parquet/types.h:
##########
@@ -64,8 +64,12 @@ struct Type {
     DOUBLE = 5,
     BYTE_ARRAY = 6,
     FIXED_LEN_BYTE_ARRAY = 7,
+
+    // This parquet type does not actually exist (AFAIK) and is used to
+    // create proper type traits
+    LARGE_BYTE_ARRAY = 8,

Review Comment:
   Yes, I agree that `TypedRecordReader` would be a challenge. However, we know 
the actual builder type from the reader properties so we can create correct 
builder accordingly. One option would be adding a `ByteArrayEncodingTraits` 
which is similar to `EncodingTraits`. Or we can extend `EncodingTraits` with an 
extra parameter to indicate int32 or int64 for binary types. Both approaches 
are ugly though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org