candiduslynx commented on code in PR #35872:
URL: https://github.com/apache/arrow/pull/35872#discussion_r1213391728
##########
go/arrow/array/compare.go:
##########
@@ -735,10 +735,14 @@ func arrayApproxEqualFixedSizeList(left, right
*FixedSizeList, opt equalOption)
}
func arrayApproxEqualStruct(left, right *Struct, opt equalOption) bool {
- for i, lf := range left.fields {
- rf := right.fields[i]
- if !arrayApproxEqual(lf, rf, opt) {
- return false
+ for i := 0; i < left.Len(); i++ {
+ if left.IsNull(i) {
+ continue
+ }
+ for j := range left.fields {
+ if !sliceApproxEqual(left.fields[j], int64(i),
int64(i+1), right.fields[j], int64(i), int64(i+1), opt) {
+ return false
+ }
}
Review Comment:
Done in fb156f8a1198495134b0841a2c4021f6b1c6f619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
