pitrou commented on code in PR #35860:
URL: https://github.com/apache/arrow/pull/35860#discussion_r1213536961
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -470,6 +471,15 @@ class ARROW_DS_EXPORT WriteNodeOptions : public
acero::ExecNodeOptions {
/// \brief Options to control how to write the dataset
FileSystemDatasetWriteOptions write_options;
+ /// \brief Optional schema to attach to all written batches
+ ///
+ /// By default, we will use the output schema of the input.
+ ///
+ /// This can be used to alter schema metadata, field nullability, or field
metadata
Review Comment:
Nit
```suggestion
/// This can be used to alter schema metadata, field nullability, or field
metadata.
```
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -34,6 +34,7 @@
#include "arrow/filesystem/filesystem.h"
#include "arrow/io/file.h"
#include "arrow/util/compression.h"
+#include "arrow/util/key_value_metadata.h"
Review Comment:
This shouldn't be necessary if `arrow/type_fwd.h` is included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
