LouisGariepy commented on issue #6496:
URL: 
https://github.com/apache/arrow-datafusion/issues/6496#issuecomment-1572756952

   > What do you think about simply moving the contents of catalog/catalog.rs 
into catalog/mod.rs ?
   
   Sounds good!
   
   > I like the idea of provider -- or likewise we could move the code up one 
level to be datasource::TableProvider (rather than 
datasource::datasource::TableProvider
   
   I don't have a strong opinion on this. Both seem like fine options to me. I 
guess it depends how many provider-Related items and implementations are 
expected to be added in the future. If it's always mostly going to stay the 
same (just `TableProvider` and `TableProviderFactory` definitions), then moving 
them to the parent module is fine. Otherwise, I'd keep the submodule.
   
   Once a consensus has been reached, I'll submit a PR to solve this :smile: 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to