alamb commented on code in PR #4341: URL: https://github.com/apache/arrow-rs/pull/4341#discussion_r1213681550
########## arrow-flight/src/sql/catalogs/mod.rs: ########## @@ -1,123 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one Review Comment: moved to metadata/mod.rs ########## arrow-flight/src/sql/mod.rs: ########## @@ -27,7 +27,7 @@ //! 2. Helpers for encoding and decoding FlightSQL messages: [`Any`] and [`Command`] //! 3. A [`FlightSqlServiceClient`] for interacting with FlightSQL servers. //! 4. A [`FlightSqlService`] to help building FlightSQL servers from [`FlightService`]. -//! 5. Structures to build responses for FlightSQL metadata APIs: [`SqlInfoList`] +//! 5. Helpers to build responses for FlightSQL metadata APIs: [`metadata`] Review Comment: I think the docs now look more unified and lead people to the `metadata` crate more easily ########## arrow-flight/src/sql/metadata/mod.rs: ########## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Builders and function for building responses to FlightSQL metadata +//! / information schema requests. +//! +//! - [`GetCatalogsBuilder`] for building responses to [`CommandGetCatalogs`] queries. +//! - [`GetDbSchemasBuilder`] for building responses to [`CommandGetDbSchemas`] queries. +//! - [`GetTablesBuilder`]for building responses to [`CommandGetTables`] queries. +//! +//! [`CommandGetCatalogs`]: crate::sql::CommandGetCatalogs +//! [`CommandGetDbSchemas`]: crate::sql::CommandGetDbSchemas +//! [`CommandGetTables`]: crate::sql::CommandGetTables + +mod catalogs; +mod db_schemas; +mod sql_info; +mod tables; + +pub use catalogs::GetCatalogsBuilder; +pub use db_schemas::GetDbSchemasBuilder; +pub use sql_info::SqlInfoList; Review Comment: As a follow on it would be awesome to make a `SqlInfoList` builder similarly to the other builders, but I ran out of time today and figured I will do it as a follow on PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
