tustvold commented on code in PR #4343:
URL: https://github.com/apache/arrow-rs/pull/4343#discussion_r1214047353
##########
arrow-data/src/transform/mod.rs:
##########
@@ -624,13 +633,18 @@ impl<'a> MutableArrayData<'a> {
}
/// Extends this [MutableArrayData] with null elements, disregarding the
bound arrays
+ ///
+ /// # Panics
+ ///
+ /// Panics if [`MutableArrayData`] not created with `use_nulls` or
nullable source arrays
+ ///
pub fn extend_nulls(&mut self, len: usize) {
- // TODO: null_buffer should probably be extended here as well
- // otherwise is_valid() could later panic
- // add test to confirm
+ self.data.len += len;
+ let bit_len = bit_util::ceil(self.data.len, 8);
+ let nulls = self.data.null_buffer();
+ nulls.resize(bit_len, 0);
self.data.null_count += len;
(self.extend_nulls)(&mut self.data, len);
Review Comment:
Despite its name this extends the **values** with nulls, it doesn't do
anything to the bit mask
##########
arrow-data/src/transform/mod.rs:
##########
@@ -624,13 +633,18 @@ impl<'a> MutableArrayData<'a> {
}
/// Extends this [MutableArrayData] with null elements, disregarding the
bound arrays
+ ///
+ /// # Panics
+ ///
+ /// Panics if [`MutableArrayData`] not created with `use_nulls` or
nullable source arrays
+ ///
pub fn extend_nulls(&mut self, len: usize) {
- // TODO: null_buffer should probably be extended here as well
- // otherwise is_valid() could later panic
- // add test to confirm
+ self.data.len += len;
+ let bit_len = bit_util::ceil(self.data.len, 8);
+ let nulls = self.data.null_buffer();
+ nulls.resize(bit_len, 0);
self.data.null_count += len;
(self.extend_nulls)(&mut self.data, len);
Review Comment:
Despite its name this extends the **values** buffers with nulls, it doesn't
do anything to the bit mask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
