NGA-TRAN commented on code in PR #6522:
URL: https://github.com/apache/arrow-datafusion/pull/6522#discussion_r1214630117
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -522,6 +522,13 @@ fn date_bin_impl(
let (stride, stride_fn) = stride.bin_fn();
+ // Return error if stride is 0
+ if stride == 0 {
Review Comment:
Since I do not know if the negative stride is therefor a specific purpose
and someone may use it, I chose not to change its behavior. I go with the
option 1 to only fix the panic and have change the error message to "DATE_BIN
stride must be non-zero"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
