aiguofer commented on code in PR #724:
URL: https://github.com/apache/arrow-adbc/pull/724#discussion_r1214637937


##########
docs/source/python/flight_sql.rst:
##########


Review Comment:
   Yeah it's possible that a single page per driver is better; it's not as easy 
to use from a user perspective, but it's a good tradeoff between 
maintainability and user experience. If the goal is to have the same general 
options and descriptions for all languages, then this is fine. If there's lots 
of exceptions (works on this language but not on that) then this could be 
cumbersome.
   
   Part of the issue is that it's already kind of half/half. When you look 
under `LANGUAGE-SPECIFIC APIS` there's still some usage examples, and then 
there's the random `Python quickstart` page.
   
   All that being said, I'll move the code examples into `go/flight_sql.rst` 
for now. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to