yyang52 commented on code in PR #35886:
URL: https://github.com/apache/arrow/pull/35886#discussion_r1217775208


##########
cpp/src/parquet/properties.h:
##########
@@ -172,8 +172,8 @@ class PARQUET_EXPORT ColumnProperties {
     max_stats_size_ = max_stats_size;
   }
 
-  void set_compression_level(int compression_level) {

Review Comment:
   seems like python codec api also takes compression_level as input, which 
also rely on cpp API (where we changed to Codec::Create(Compression::type, 
CodecOptions)). should we also modify python API or keep 
Codec::Create(Compression::type, compression_level)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to