seddonm1 commented on a change in pull request #8906:
URL: https://github.com/apache/arrow/pull/8906#discussion_r542706632
##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -400,7 +400,7 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query:
usize) -> Result<Logic
(n1.n_name = 'FRANCE' and n2.n_name = 'GERMANY')
or (n1.n_name = 'GERMANY' and n2.n_name = 'FRANCE')
)
- and l_shipdate > date '1995-01-01' and l_shipdate <
date '1996-12-31'
+ and l_shipdate between date '1995-01-01' and date
'1996-12-31'
Review comment:
When implementing BETWEEN I went hunting for the ANSI SQL spec but the
best I could do is find the Postgres implementation which confirms it is
definitely INCLUSIVE.
https://www.postgresql.org/docs/13/functions-comparison.html
```
The BETWEEN predicate simplifies range tests:
a BETWEEN x AND y
is equivalent to
a >= x AND a <= y
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
