dadepo commented on code in PR #4364:
URL: https://github.com/apache/arrow-rs/pull/4364#discussion_r1217900578
##########
arrow-array/src/array/map_array.rs:
##########
@@ -284,6 +292,18 @@ impl Array for MapArray {
}
}
+impl<'a> ArrayAccessor for &'a MapArray {
+ type Item = ArrayRef;
Review Comment:
Yeah, just thinking without that, the consumer will always be forced to cast
back to `StructArray`.
I'll update it in a bit
##########
arrow-array/src/array/map_array.rs:
##########
@@ -284,6 +292,18 @@ impl Array for MapArray {
}
}
+impl<'a> ArrayAccessor for &'a MapArray {
+ type Item = ArrayRef;
Review Comment:
Yeah, just thinking, without that, the consumer will always be forced to
cast back to `StructArray`.
I'll update it in a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
