tustvold commented on code in PR #4367:
URL: https://github.com/apache/arrow-rs/pull/4367#discussion_r1218315214
##########
arrow-ord/src/comparison.rs:
##########
@@ -1196,8 +1196,7 @@ where
K: ArrowDictionaryKeyType,
K::Native: num::ToPrimitive,
{
- // TODO: Use take_boolean (#2967)
- let array = take(&dict_comparison, dict.keys(), None)?;
+ let array = take_boolean(&dict_comparison, dict.keys())?;
Review Comment:
```suggestion
let array = take(&dict_comparison, dict.keys())?.as_boolean().clone();
```
Perhaps? The overhead of the dyn dispatch and clone is irrelevant in the
grand scheme of things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
