felipecrv commented on code in PR #35750:
URL: https://github.com/apache/arrow/pull/35750#discussion_r1218610215
##########
cpp/src/arrow/compute/kernels/vector_selection_internal.cc:
##########
@@ -239,6 +309,43 @@ struct Selection {
}
};
+ if (is_ree_filter) {
+ Status status;
Review Comment:
When I started with the numeric kernels there was no way for `emit_segment`
to fail. Making it return `Status` will create overhead in
`VisitPlainxREEFilterOutputSegments` when it's dealing with primitives.
Should I worry about the overhead of checking for the status returned by
`std::function` in the context of primitive kernels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
