tdhock commented on issue #35577:
URL: https://github.com/apache/arrow/issues/35577#issuecomment-1577810749
Also, I think there is some confusion between -rpath flags and -lthrift
flag.
Actually, I have no problem with the rpath, that is normal that I set it in
my ~/.R/Makevars file, because that is how to tell R to look for libraries to
link against in non-standard directories, via `LDFLAGS=-L${HOME}/lib
-Wl,-rpath=${HOME}/lib -L${CONDA_PREFIX}/lib -Wl,-rpath=${CONDA_PREFIX}/lib`,
it is completely normal/standard to do that when you have C++ libraries
installed in non-standard directories. So your suggestion to modify the rpath
via cmake -DCMAKE_INSTALL_RPATH=${CONDA_PREFIX}/lib ... I don't think would fix
this issue though, because I told the R linker command about my non-standard
rpath already via LDFLAGS in ~/.R/Makevars.
My issue is that the `-lthrift` flag is missing from the linker command
line, when creating the R package arrow.so file, so I get a broken link to
thrift, and an error when I try to install the R package (without setting
LD_LIBRARY_PATH). I believe that since R arrow depends on thrift (even if
indirectly through parquet), then it is your responsibility to ensure that your
build script creates a shared library with a valid link to thrift, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
