wgtmac commented on code in PR #35930:
URL: https://github.com/apache/arrow/pull/35930#discussion_r1219218477
##########
cpp/src/parquet/properties.h:
##########
@@ -147,14 +148,16 @@ class PARQUET_EXPORT ColumnProperties {
bool dictionary_enabled = DEFAULT_IS_DICTIONARY_ENABLED,
bool statistics_enabled = DEFAULT_ARE_STATISTICS_ENABLED,
size_t max_stats_size = DEFAULT_MAX_STATISTICS_SIZE,
- bool page_index_enabled = DEFAULT_IS_PAGE_INDEX_ENABLED)
+ bool page_index_enabled = DEFAULT_IS_PAGE_INDEX_ENABLED,
+ bool column_index_enabled = DEFAULT_IS_COLUMN_INDEX_ENABLED)
: encoding_(encoding),
codec_(codec),
dictionary_enabled_(dictionary_enabled),
statistics_enabled_(statistics_enabled),
max_stats_size_(max_stats_size),
compression_level_(Codec::UseDefaultCompressionLevel()),
- page_index_enabled_(DEFAULT_IS_PAGE_INDEX_ENABLED) {}
+ page_index_enabled_(page_index_enabled),
Review Comment:
This feature is pretty new so I think it should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]